Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creating None enum flag with Enum.from_value #6516

Conversation

Projects
None yet
4 participants
@bew
Copy link
Contributor

commented Aug 10, 2018

Fixes #5768

It also adds type restrictions to Int, and fix one usage in src/debug/elf.cr

@bew bew force-pushed the bew:allow-creating-none-enum-flags-from-value branch from c62e23a to 5736077 Aug 10, 2018

@bew

This comment has been minimized.

Copy link
Contributor Author

commented Dec 27, 2018

Good to go? (one of travis check failed for another reason)

@RX14

RX14 approved these changes Dec 27, 2018

@RX14

This comment has been minimized.

Copy link
Member

commented Dec 27, 2018

Can this be rebased on master so we're sure there are no more spec failures?

@bew bew force-pushed the bew:allow-creating-none-enum-flags-from-value branch from 5736077 to b7fca2b Dec 27, 2018

Show resolved Hide resolved src/debug/elf.cr
@bew

This comment has been minimized.

Copy link
Contributor Author

commented Dec 28, 2018

So I rebased on master, one of travis job fails for a weird reason: https://travis-ci.org/crystal-lang/crystal/jobs/472825523

@RX14

This comment has been minimized.

Copy link
Member

commented Dec 28, 2018

@bew thats just OOM

@bew

This comment has been minimized.

Copy link
Contributor Author

commented Dec 28, 2018

that's just OOM

yeah sure, but it's still not wanted^^

@RX14

This comment has been minimized.

Copy link
Member

commented Dec 28, 2018

Travis builds randomly fail from OOM all the time

@straight-shoota straight-shoota added this to the 0.28.0 milestone Dec 31, 2018

@straight-shoota

This comment has been minimized.

Copy link
Member

commented Feb 11, 2019

@bew Could you rebase on master to make sure it's still valid?

@bew bew force-pushed the bew:allow-creating-none-enum-flags-from-value branch from b7fca2b to 8b7f7b5 Feb 11, 2019

@straight-shoota straight-shoota merged commit 90dba4d into crystal-lang:master Feb 15, 2019

5 checks passed

ci/circleci: check_format Your tests passed on CircleCI!
Details
ci/circleci: test_darwin Your tests passed on CircleCI!
Details
ci/circleci: test_linux Your tests passed on CircleCI!
Details
ci/circleci: test_linux32 Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bew bew deleted the bew:allow-creating-none-enum-flags-from-value branch Feb 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.