New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore #bind_ssl as deprecated api #6551

Merged
merged 2 commits into from Aug 19, 2018

Conversation

Projects
None yet
3 participants
@bcardiff
Member

bcardiff commented Aug 16, 2018

Restores HTTP::Server#bind_ssl removed by #6533 so the current master can be used to ship 0.26.1 without breaking changes.

HTTP::Server#bind_ssl can be removed in 0.27

@bcardiff bcardiff added this to the Next milestone Aug 16, 2018

@@ -258,6 +258,11 @@ class HTTP::Server
def bind_tls(address : Socket::IPAddress, context : OpenSSL::SSL::Context::Server) : Socket::IPAddress
bind_tls(address.address, address.port, context)
end
# DEPRECATED: Use `#bind_tls`.

This comment has been minimized.

@RX14

RX14 Aug 17, 2018

Member

Please add an explicit TODO: remove in 0.27.0 or similar

we should probably eventually settle on a TODO(0.27.0) style with a grep -R "TODO($(crystal -v))" src spec to fail the build. when you upgrade the compiler.

Which also reminds me that there should be a crystal -v which is machine-readable not human-readable....

This comment has been minimized.

@bcardiff
@RX14

RX14 approved these changes Aug 19, 2018

@RX14 RX14 merged commit 202e5ac into crystal-lang:master Aug 19, 2018

4 checks passed

ci/circleci: test_darwin Your tests passed on CircleCI!
Details
ci/circleci: test_linux Your tests passed on CircleCI!
Details
ci/circleci: test_linux32 Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@RX14 RX14 added the kind:feature label Aug 19, 2018

omarroth added a commit to omarroth/crystal that referenced this pull request Nov 5, 2018

Restore #bind_ssl as deprecated api (crystal-lang#6551)
* Restore #bind_ssl as deprecated api

* Add TODO remove note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment