New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make self to be eager evaluated when including modules #6557

Merged
merged 1 commit into from Aug 20, 2018

Conversation

Projects
None yet
2 participants
@bcardiff
Member

bcardiff commented Aug 17, 2018

Also fixes #6547. It reverts the semantic changes of #3972 according to #3972 (comment)

I review the specs added and changed them accordingly to the linked discussion

This can supersedes #6549

cc: @asterite , @MakeNowJust , @paulcsmith

@bcardiff bcardiff added this to the 0.26.1 milestone Aug 17, 2018

@RX14

RX14 approved these changes Aug 18, 2018

@bcardiff bcardiff merged commit ea543f3 into crystal-lang:master Aug 20, 2018

4 checks passed

ci/circleci: test_darwin Your tests passed on CircleCI!
Details
ci/circleci: test_linux Your tests passed on CircleCI!
Details
ci/circleci: test_linux32 Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

omarroth added a commit to omarroth/crystal that referenced this pull request Nov 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment