Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move HTTP::Multipart to MIME::Multipart #7085

Conversation

@m1lt0n
Copy link
Contributor

commented Nov 14, 2018

This is implementing the proposal of issue #7078

@m1lt0n m1lt0n force-pushed the m1lt0n:move_multipart_and_formdata_to_mime branch 3 times, most recently from cc338fd to 67c46f1 Nov 14, 2018

@m1lt0n m1lt0n changed the title Move HTTP::Formdata and HTTP::Multipart to Mime namespace Move HTTP::FormData and HTTP::Multipart to Mime namespace Nov 14, 2018

@ysbaddaden

This comment has been minimized.

Copy link
Member

commented Nov 14, 2018

I'd never expect MIME::FormData. I'd expect HTTP::FormData.

@m1lt0n

This comment has been minimized.

Copy link
Contributor Author

commented Nov 14, 2018

@ysbaddaden Yep, agree, it's kind of subjective. I have started working on crystal projects lately and wanted to start contributed somehow, so I went for a quick win based on an open issue. It's totally up for discussion if this should be merged as is or with amendments :)

@straight-shoota

This comment has been minimized.

Copy link
Member

commented Nov 14, 2018

@m1lt0n I opened an issue instead of a PR so this can be discussed first. Lets please talk about the general proceeding in #7078 and then come back to this PR.

@m1lt0n

This comment has been minimized.

Copy link
Contributor Author

commented Nov 14, 2018

@straight-shoota Sure! That was my intention too. Sorry if the PR took some time from people to look at it. My intention was to have a PR ready (that's why I referenced it in the PR) if the issue discussion proceeds and gets accepted as is (or with some ammendments based on the discussion on the issue). Thanks for your feedback.

@straight-shoota

This comment has been minimized.

Copy link
Member

commented Dec 10, 2018

@m1lt0n Could you revert to HTTP::FormData as per #7078 ?

@m1lt0n m1lt0n force-pushed the m1lt0n:move_multipart_and_formdata_to_mime branch 2 times, most recently from cd70035 to 25e9acf Dec 10, 2018

@m1lt0n

This comment has been minimized.

Copy link
Contributor Author

commented Dec 10, 2018

@straight-shoota Ok, done. Moved the changes of FormData back to HTTP.

@straight-shoota
Copy link
Member

left a comment

src/http/formdata.cr needs to have require "mime/multipart" as well.

Show resolved Hide resolved spec/std/mime/multipart/builder_spec.cr Outdated
Show resolved Hide resolved spec/std/mime/multipart/parser_spec.cr Outdated
Show resolved Hide resolved spec/std/mime/multipart_spec.cr Outdated
Show resolved Hide resolved src/mime.cr Outdated
Show resolved Hide resolved src/mime/multipart.cr Outdated
@straight-shoota
Copy link
Member

left a comment

👍

@RX14

RX14 approved these changes Dec 15, 2018

@asterite
Copy link
Member

left a comment

Please check if this can be merged right now, it's a breaking change so probably not suitable for 0.27.1

@sdogruyol
Copy link
Member

left a comment

Thank you @m1lt0n 👍

@vlazar

This comment has been minimized.

Copy link
Contributor

commented Jan 7, 2019

Maybe update PR title as HTTP::FormData is no longer moved to Mime:: namespace?

Move HTTP::FormData and HTTP::Multipart to Mime namespace -> Move HTTP::Multipart to MIME namespace

@straight-shoota straight-shoota changed the title Move HTTP::FormData and HTTP::Multipart to Mime namespace Move HTTP::Multipart to MIME::Multipart Jan 7, 2019

@bcardiff

This comment has been minimized.

Copy link
Member

commented Feb 7, 2019

@m1lt0n there are some conflicts since the last release. Would you be willing to rebase & fix on master so this can be merged?

@m1lt0n m1lt0n force-pushed the m1lt0n:move_multipart_and_formdata_to_mime branch from e054091 to 6b25e16 Feb 8, 2019

@straight-shoota
Copy link
Member

left a comment

Thank you! 👍

@straight-shoota straight-shoota merged commit c163a85 into crystal-lang:master Feb 8, 2019

5 checks passed

ci/circleci: check_format Your tests passed on CircleCI!
Details
ci/circleci: test_darwin Your tests passed on CircleCI!
Details
ci/circleci: test_linux Your tests passed on CircleCI!
Details
ci/circleci: test_linux32 Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@yorci yorci referenced this pull request Apr 19, 2019

Merged

Crystal 0.28.0 Adaptation #62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.