New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler: allow trailing commas inside tuple types #7182

Merged
merged 1 commit into from Dec 13, 2018

Conversation

Projects
None yet
4 participants
@asterite
Copy link
Contributor

asterite commented Dec 13, 2018

This is a small enhancement. Trailing commas are super useful when generating code with macros, to not care about putting that one extra comma at the end.

@asterite asterite merged commit d87e23c into crystal-lang:master Dec 13, 2018

4 checks passed

ci/circleci: test_darwin Your tests passed on CircleCI!
Details
ci/circleci: test_linux Your tests passed on CircleCI!
Details
ci/circleci: test_linux32 Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@asterite asterite modified the milestones: 0.28.0, 0.27.1 Dec 13, 2018

@bcardiff

This comment has been minimized.

Copy link
Member

bcardiff commented Dec 13, 2018

I would say it's a language change rather and a compiler bug :-)

@asterite asterite added kind:feature and removed kind:bug labels Dec 13, 2018

@asterite

This comment has been minimized.

Copy link
Contributor Author

asterite commented Dec 13, 2018

@bcardiff Good call, I changed the label to kind:feature.

@bcardiff bcardiff added topic:lang and removed topic:compiler labels Jan 28, 2019

@pynixwang

This comment has been minimized.

Copy link

pynixwang commented Feb 13, 2019

join(",")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment