Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement #annotations #7326

Merged
merged 6 commits into from Feb 23, 2019

Conversation

@Blacksmoke16
Copy link
Contributor

commented Jan 20, 2019

Resolves #7316

Feedback welcome.

Show resolved Hide resolved src/compiler/crystal/semantic/ast.cr Outdated
Show resolved Hide resolved src/compiler/crystal/semantic/ast.cr Outdated
Show resolved Hide resolved src/compiler/crystal/types.cr Outdated
Show resolved Hide resolved src/compiler/crystal/semantic/ast.cr Outdated
Show resolved Hide resolved src/compiler/crystal/macros.cr Outdated
@vladfaust

This comment has been minimized.

Copy link
Contributor

commented Jan 20, 2019

Astonished by the amount of specs. Good job, @Blacksmoke16 👍

@Blacksmoke16

This comment has been minimized.

Copy link
Contributor Author

commented Jan 20, 2019

Spec failure isn't related I don't think.

@Blacksmoke16

This comment has been minimized.

Copy link
Contributor Author

commented Jan 23, 2019

This should be ready for review now.

@asterite
Copy link
Member

left a comment

Looks good! Just a request to indent code snippets in tests, and then I'll approve :-)

@Blacksmoke16

This comment has been minimized.

Copy link
Contributor Author

commented Jan 23, 2019

@asterite Done.

@RX14

RX14 approved these changes Jan 25, 2019

@Blacksmoke16

This comment has been minimized.

Copy link
Contributor Author

commented Feb 1, 2019

@asterite This should be good now.

@vladfaust

This comment has been minimized.

Copy link
Contributor

commented Feb 6, 2019

Should it be possible to return all annotations on a type?
I.e. TypeNode#annotations : ArrayLiteral(Annotation)

@straight-shoota

This comment has been minimized.

Copy link
Member

commented Feb 15, 2019

@Blacksmoke16 Can you rebase this branch on master to make sure it's all still good?

@straight-shoota straight-shoota added this to the 0.28.0 milestone Feb 15, 2019

@Blacksmoke16

This comment has been minimized.

Copy link
Contributor Author

commented Feb 15, 2019

@straight-shoota Yea i can do when i get home. Should add in the Update Branch button ;)

https://github.blog/2015-09-03-protected-branches-and-required-status-checks/

@sdogruyol
Copy link
Member

left a comment

Thank you @Blacksmoke16 👍

@straight-shoota straight-shoota merged commit 25218a5 into crystal-lang:master Feb 23, 2019

5 checks passed

ci/circleci: check_format Your tests passed on CircleCI!
Details
ci/circleci: test_darwin Your tests passed on CircleCI!
Details
ci/circleci: test_linux Your tests passed on CircleCI!
Details
ci/circleci: test_linux32 Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

urde-graven pushed a commit to urde-graven/crystal that referenced this pull request Feb 25, 2019

urde-graven pushed a commit to urde-graven/crystal that referenced this pull request Feb 27, 2019

Urde Graven
Merge branch 'fixes'
* fixes:
  Foreign exceptions: basic support
  Added support for `.so' libraries, fixed segfault, small bugs
  OptionParser: optional options and arguments shifting
  XML: workaround for bug in libxml2 2.9.9 (crystal-lang#7477)
  Implement resource owner credentials (crystal-lang#7424)
  Implement #annotations (crystal-lang#7326)
  Handle signals in a separate fiber
  Compiler: reactively compute a union's type, and check for missing types
  Compiler: fix as? casting when target doesn't have a type yet
  Compiler: fix as casting when target doesn't have a type yet
  Compiler: give pare error when assigning a constant inside a multiassign
  Format: fix indent of nested array elements (crystal-lang#7450)
  Disable double write buffering in OpenSSL sockets (crystal-lang#7460)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.