Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract Fiber::StackPool #7417

Merged
merged 1 commit into from Mar 7, 2019

Conversation

@ysbaddaden
Copy link
Member

commented Feb 12, 2019

Keeps stack operations (allocate, recycle, free) out of Fiber itself.

Just a mere extraction; not MT-safe but will be easy to add —e.g. use a mutex to protect the deque.pop?, deque.push and deque.shift? calls.

@ysbaddaden ysbaddaden force-pushed the ysbaddaden:core/fiber-stack-pool branch from dd1e4dd to 0eae734 Feb 12, 2019

@ysbaddaden

This comment has been minimized.

Copy link
Member Author

commented Feb 12, 2019

The circle/linux job failed, but the error seems unrelated:

1) TCPSocket fails when connection is refused
   Failure/Error: expect_raises_errno(Errno::ECONNREFUSED, "Error connecting to 'localhost:#{port}'") do
     Expected Errno but nothing was raised
   # spec/std/socket/tcp_socket_spec.cr:132
@asterite

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

We should note those CI errors and try to fix them. Lately I've been trying to get a CI that we can trust but it seems we are still missing a few cases.

@straight-shoota

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

@asterite The hard thing is recognizing repeated instances of the same CI failure. A single random connection error simply isn't really worth noting because it could happen for many reasons and most of them are out of our control.

@sdogruyol

This comment has been minimized.

Copy link
Member

commented Feb 15, 2019

Are we holding this just because of the CI failure?

@asterite

This comment has been minimized.

Copy link
Member

commented Feb 15, 2019

I just re-ran it.

@sdogruyol

This comment has been minimized.

Copy link
Member

commented Feb 18, 2019

@asterite should be good to 🚢

Show resolved Hide resolved src/fiber.cr Outdated
@asterite
Copy link
Member

left a comment

Looks good! Just a small request

Show resolved Hide resolved src/fiber.cr Outdated
Extract Fiber::StackPool
Keeps stack operations (allocate, recycle, free) out of Fiber itself.

@ysbaddaden ysbaddaden force-pushed the ysbaddaden:core/fiber-stack-pool branch from 0eae734 to 15c65cb Feb 18, 2019

@straight-shoota
Copy link
Member

left a comment

Should be ready to merge?

@straight-shoota straight-shoota added this to the 0.28.0 milestone Mar 5, 2019

@ysbaddaden ysbaddaden merged commit 2a65a98 into crystal-lang:master Mar 7, 2019

5 checks passed

ci/circleci: check_format Your tests passed on CircleCI!
Details
ci/circleci: test_darwin Your tests passed on CircleCI!
Details
ci/circleci: test_linux Your tests passed on CircleCI!
Details
ci/circleci: test_linux32 Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ysbaddaden ysbaddaden deleted the ysbaddaden:core/fiber-stack-pool branch Mar 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.