Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler: let `protected initialize` define a protected `new` #7510

Merged
merged 1 commit into from Mar 8, 2019

Conversation

Projects
None yet
3 participants
@asterite
Copy link
Member

commented Mar 4, 2019

Fixes #7501

@asterite

This comment has been minimized.

Copy link
Member Author

commented Mar 4, 2019

There seems to be a problem with included modules. This needs a bit more tweaking... I'll fix it later.

@asterite asterite force-pushed the asterite:bug/protected-initialize branch from 5f1da45 to 81f247e Mar 4, 2019

@asterite asterite force-pushed the asterite:bug/protected-initialize branch from 81f247e to 3ef243c Mar 7, 2019

@asterite asterite requested review from bcardiff, RX14 and ysbaddaden Mar 8, 2019

@bcardiff
Copy link
Member

left a comment

This looks great. And how public initializers are translated to public new + protected initializers is pretty clean.

@asterite asterite added this to the 0.28.0 milestone Mar 8, 2019

@asterite asterite merged commit dc337b8 into crystal-lang:master Mar 8, 2019

5 checks passed

ci/circleci: check_format Your tests passed on CircleCI!
Details
ci/circleci: test_darwin Your tests passed on CircleCI!
Details
ci/circleci: test_linux Your tests passed on CircleCI!
Details
ci/circleci: test_linux32 Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@asterite asterite deleted the asterite:bug/protected-initialize branch Mar 30, 2019

@bcardiff bcardiff added topic:lang and removed topic:lang labels Apr 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.