Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler: fix named args type matching #7529

Merged
merged 1 commit into from Mar 9, 2019

Conversation

Projects
None yet
5 participants
@asterite
Copy link
Member

commented Mar 8, 2019

Fixes #7523

The order of matching named arguments type was wrong (match vs. signature but should have been the other way around).

@bcardiff
Copy link
Member

left a comment

It bugs me that compatible_with? seems to denote a symmetric relation while it is actually more similar to the subtyping relationship. But it's a story for later refactors.

@asterite

This comment has been minimized.

Copy link
Member Author

commented Mar 8, 2019

Yeah, it should probably be named "can be cast to", but in general the whole matching logic should be refactored. This is just a small patch.

@RX14

RX14 approved these changes Mar 9, 2019

@RX14 RX14 added this to the 0.28.0 milestone Mar 9, 2019

@RX14 RX14 merged commit 05e2e4b into crystal-lang:master Mar 9, 2019

5 checks passed

ci/circleci: check_format Your tests passed on CircleCI!
Details
ci/circleci: test_darwin Your tests passed on CircleCI!
Details
ci/circleci: test_linux Your tests passed on CircleCI!
Details
ci/circleci: test_linux32 Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@paulcsmith

This comment has been minimized.

Copy link
Contributor

commented Mar 9, 2019

Awesome! Can't wait to try this out on some stuff I'm working on. I just noticed there is a highly docker build so I'll give that a try later. Thanks for fixing this!

@asterite asterite deleted the asterite:bug/7523-proc-named-args branch Mar 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.