Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Slice#pointer #7581

Merged

Conversation

@Maroo-b
Copy link
Contributor

commented Mar 23, 2019

Issue: #7004
As discussed with @straight-shoota and @asterite Slice#pointer is a confusing method and it should be removed.
The code was refactored to keep the verification logic in Slice mainly for copy methods.

I was thinking if we should add a deprecation warning or just mention this as a breaking change in case someone is using Slice#pointer.

src/slice.cr Show resolved Hide resolved
src/slice.cr Outdated Show resolved Hide resolved

@Maroo-b Maroo-b force-pushed the Maroo-b:7004_remove_slice_pointer_method branch 3 times, most recently from 9ee2f84 to 5d2d998 Apr 2, 2019

src/regex.cr Outdated Show resolved Hide resolved
@straight-shoota
Copy link
Member

left a comment

Apart from this minor improvement, this is GTG!

Remove Slice#pointer
Issue: #7004
Slice#pointer caused confusion and it used mainly for verification.

@Maroo-b Maroo-b force-pushed the Maroo-b:7004_remove_slice_pointer_method branch from 5d2d998 to 0337409 Apr 3, 2019

@sdogruyol
Copy link
Member

left a comment

Thank you @Maroo-b 🙏

@asterite asterite merged commit 64d0a1d into crystal-lang:master May 30, 2019

5 checks passed

ci/circleci: check_format Your tests passed on CircleCI!
Details
ci/circleci: test_darwin Your tests passed on CircleCI!
Details
ci/circleci: test_linux Your tests passed on CircleCI!
Details
ci/circleci: test_linux32 Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@asterite asterite added this to the 0.29.0 milestone May 30, 2019

@Maroo-b Maroo-b deleted the Maroo-b:7004_remove_slice_pointer_method branch Jun 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.