Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Add deprecation message to PartialComparable #7664
The issue with detecting the deprecation of
module Foo @[Deprecated] abstract def foo end class Bar include Foo def foo 1 end end puts Bar.new.foo
That is the same story as identifing if a method is overriding or declaring a new method.
I this case the best thing to do is deprecate the constant/module itself.
It would be great to detect mentions of deprecated constants after 0.28.
bcardiff left a comment
WDYT about using the annotation?
@[Deprecated("This module is deprecated as of Crystal 0.28.0. Its behaviour has been fully integrated into `Comparable`.")]
@straight-shoota, when I checked locally the deprecation, is only emitted if it goes before the docs comment.