Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix examples 2019 04 #7718

Merged
merged 9 commits into from May 6, 2019

Conversation

@maiha
Copy link
Contributor

commented Apr 25, 2019

Congrats 0.28.0! Let's catch up the examples code too!

For convenience, commits are divided file by file, so please apply squash merge.

Best regards,

maiha added some commits Apr 2, 2019

examples: fix Path
- Fix missing comment on the code example
- Fix to use double backslashes
- Fix anchor and drive
examples: fix HTTP::Formadata
- Remove dependency on `tempfile`
examples: fix String
- expected named argument
src/string.cr Show resolved Hide resolved
@r00ster91 r00ster91 referenced this pull request Apr 25, 2019
src/path.cr Outdated Show resolved Hide resolved
src/time.cr Outdated Show resolved Hide resolved
@straight-shoota
Copy link
Member

left a comment

Sorry, I missed two instances that need double backslash escapes as well:

src/path.cr Outdated Show resolved Hide resolved
src/path.cr Outdated Show resolved Hide resolved
examples: fix Path
- two more instances that need double backslash escapes as well
@maiha

This comment has been minimized.

Copy link
Contributor Author

commented May 5, 2019

It seems that everything is fine. It's time to merge. 😺

@asterite asterite added this to the 0.29.0 milestone May 6, 2019

@asterite asterite merged commit aad3646 into crystal-lang:master May 6, 2019

5 checks passed

ci/circleci: check_format Your tests passed on CircleCI!
Details
ci/circleci: test_darwin Your tests passed on CircleCI!
Details
ci/circleci: test_linux Your tests passed on CircleCI!
Details
ci/circleci: test_linux32 Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@RX14

This comment has been minimized.

Copy link
Member

commented May 6, 2019

@maiha thank you so much for doing these PRs! It's really appreciated ❤️

@maiha maiha deleted the maiha:fix-examples-2019-04 branch May 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.