Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect deprecation on initialize methods and methods with named args #7724

Merged
merged 2 commits into from May 2, 2019

Conversation

@bcardiff
Copy link
Member

commented Apr 28, 2019

Annotations were not kept from the original method to the expanded overload for named args.
For generated .new methods the annotations of the matching #initialize should be kept.

The call from new to initialize should not generate a warning since it's an implementation detail. For this case, an explicit check following the convention used by the compiler is used.

Fixes #7714

@bcardiff bcardiff added this to the 0.29.0 milestone Apr 28, 2019

@bcardiff bcardiff force-pushed the bcardiff:fix/deprecated-named-args branch from e0fd5fd to 7730e99 Apr 30, 2019

@asterite asterite merged commit 4e1e9cb into crystal-lang:master May 2, 2019

5 checks passed

ci/circleci: check_format Your tests passed on CircleCI!
Details
ci/circleci: test_darwin Your tests passed on CircleCI!
Details
ci/circleci: test_linux Your tests passed on CircleCI!
Details
ci/circleci: test_linux32 Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.