Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bcrypt: rename `Password#==` to `Password#verify` #7790

Merged

Conversation

@asterite
Copy link
Member

commented May 17, 2019

Fixes #7753

src/crypto/bcrypt/password.cr Outdated Show resolved Hide resolved
@oprypin

This comment has been minimized.

Copy link
Contributor

commented May 17, 2019

Maybe not breaking-change if it's just deprecated

@bcardiff

This comment has been minimized.

Copy link
Member

commented May 17, 2019

@oprypin I know, but we agree that at least for the time being we are tagged them as breaking for better visibility in the release notes.

@Sija

This comment has been minimized.

Copy link
Contributor

commented May 17, 2019

I'd still suggest to rename the method to verify? to make it obvious it's returning a Bool.

@asterite

This comment has been minimized.

Copy link
Member Author

commented May 17, 2019

@Sija But verify? isn't proper English, same reason we have includes? and not include?. I think verify is fine. I would have liked matches? but others agreed with using verify or verify? (but verify? is inconsistent to me).

Update src/crypto/bcrypt/password.cr
Co-Authored-By: Brian J. Cardiff <bcardiff@gmail.com>

@asterite asterite added this to the 0.29.0 milestone May 17, 2019

@asterite asterite merged commit 5e464b2 into crystal-lang:master May 17, 2019

5 checks passed

ci/circleci: check_format Your tests passed on CircleCI!
Details
ci/circleci: test_darwin Your tests passed on CircleCI!
Details
ci/circleci: test_linux Your tests passed on CircleCI!
Details
ci/circleci: test_linux32 Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@asterite asterite deleted the asterite:refactor/bcrypt-password-verify branch May 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.