Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler: fix a couple of issues with while and rescue #7806

Merged
merged 1 commit into from May 30, 2019

Conversation

@asterite
Copy link
Member

commented May 21, 2019

Fixes #7786
Fixes #7572

I originally wanted to fix #7786 but it seems my fix also fixed #7572, so yay! 馃帀

The explanation for the fix is hard so I'll omit it this time, but if CI passes it probably means the changes are good :-)

(and you can see the diff is tiny)

@asterite asterite added this to the 0.29.0 milestone May 23, 2019

@asterite asterite requested a review from bcardiff May 24, 2019

@asterite asterite merged commit bb3cca6 into crystal-lang:master May 30, 2019

5 checks passed

ci/circleci: check_format Your tests passed on CircleCI!
Details
ci/circleci: test_darwin Your tests passed on CircleCI!
Details
ci/circleci: test_linux Your tests passed on CircleCI!
Details
ci/circleci: test_linux32 Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@asterite asterite deleted the asterite:bug/while branch May 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.