Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler: fully track AST nodes name location #7827

Merged
merged 3 commits into from May 31, 2019

Conversation

@asterite
Copy link
Member

commented May 28, 2019

Fixes #6937

Contains a minor refactor too.

asterite added some commits May 28, 2019

Compiler: remove optional properties from AST nodes constructors
Stuff like `name_location` or `has_parentheses` is totally optional when
constructing some AST nodes and it makes more sense to set these using
properties instead of specifying optional arguments in the constructor.
It makes the code and the API cleaner.
@bcardiff
Copy link
Member

left a comment

I was a bit worried if the JSON format of an exception was changing in a way the playground would break. But it seems that that is not changing 🎉

@asterite asterite added this to the 0.29.0 milestone May 31, 2019

@asterite asterite merged commit f0cd45c into crystal-lang:master May 31, 2019

5 checks passed

ci/circleci: check_format Your tests passed on CircleCI!
Details
ci/circleci: test_darwin Your tests passed on CircleCI!
Details
ci/circleci: test_linux Your tests passed on CircleCI!
Details
ci/circleci: test_linux32 Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@asterite asterite deleted the asterite:bug/name-location branch May 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.