Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow running compiler_specs with specific flags #7837

Merged
merged 2 commits into from May 31, 2019

Conversation

@bcardiff
Copy link
Member

commented May 31, 2019

Fixes #7805

This PR solves the mentioned issue in the narrowest way: 1.a (only affecting the specs) + 2.a (only allowing compiler flags).

This is use full for testing compiler features behind flags locally and could be used for testing compiler with different configurations in CI.

Add CRYSTAL_SPEC_COMPILER_FLAGS env var
Use CRYSTAL_SPEC_COMPILER_FLAGS env var to run the compiler specs against a compiler with the specified options
spec/spec_helper.cr Outdated Show resolved Hide resolved
Update spec/spec_helper.cr
Co-Authored-By: Julien Reichardt <mi@jrei.ch>

@bcardiff bcardiff added this to the 0.29.0 milestone May 31, 2019

@bcardiff bcardiff merged commit e7969db into crystal-lang:master May 31, 2019

5 checks passed

ci/circleci: check_format Your tests passed on CircleCI!
Details
ci/circleci: test_darwin Your tests passed on CircleCI!
Details
ci/circleci: test_linux Your tests passed on CircleCI!
Details
ci/circleci: test_linux32 Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bcardiff bcardiff deleted the bcardiff:feature/spec-compiler-flags branch Jun 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.