Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Def#to_s with **options and &block #7854

Merged

Conversation

@MakeNowJust
Copy link
Contributor

commented Jun 4, 2019

Fixed #7853

It's quite simple bug: missing a line printed_arg = true on outputting **options. Thank you.

@jhass
jhass approved these changes Jun 4, 2019

@bcardiff bcardiff added this to the 0.29.0 milestone Jun 4, 2019

@bcardiff bcardiff merged commit b78dfbd into crystal-lang:master Jun 4, 2019

5 checks passed

ci/circleci: check_format Your tests passed on CircleCI!
Details
ci/circleci: test_darwin Your tests passed on CircleCI!
Details
ci/circleci: test_linux Your tests passed on CircleCI!
Details
ci/circleci: test_linux32 Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bcardiff

This comment has been minimized.

Copy link
Member

commented Jun 4, 2019

Thanks @MakeNowJust !

@MakeNowJust MakeNowJust deleted the MakeNowJust:fix/7853-def-block-arg-to-s branch Jun 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.