Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue with aarch64 invalid memory access #7983

Merged

Conversation

@drujensen
Copy link
Contributor

commented Jul 22, 2019

This change properly maps the 64bit Intrinsics memory methods for aarch64 architecture.

This fixes issue #7293 and possibly #7299

Fixes issue with aarch64 invalid memory access
This change properly maps the 64bit Intrinsic alloc method for aarch64 architecture.

This fixes issue #7299
@asterite

This comment has been minimized.

Copy link
Member

commented Jul 22, 2019

Thank you!

I think we have a bits64 flag. It's checked in other parts of the code.

@asterite

This comment has been minimized.

Copy link
Member

commented Jul 23, 2019

Maybe also fixes #7983

src/intrinsics.cr Outdated Show resolved Hide resolved
Update src/intrinsics.cr
use `bits64` instead

Co-Authored-By: Ary Borenszweig <asterite@gmail.com>

@ysbaddaden ysbaddaden merged commit 6e3f384 into crystal-lang:master Jul 23, 2019

4 of 5 checks passed

ci/circleci: test_darwin Your tests failed on CircleCI
Details
ci/circleci: check_format Your tests passed on CircleCI!
Details
ci/circleci: test_linux Your tests passed on CircleCI!
Details
ci/circleci: test_linux32 Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ysbaddaden

This comment has been minimized.

Copy link
Member

commented Jul 23, 2019

Thank you 🙇

@bcardiff bcardiff added this to the 0.30.0 milestone Jul 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.