Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Turn abstract return type erros into warnings #7999
Jul 27, 2019
5 checks passed
After this PR these warnings are always emitted, despite
Without these two checks, the compiler is a bit more pedantic.
I'm checking if we are satisfied with that current state before releasing
If we would go that route the warning message would need to have a category field and location so that logic is handled in a single place.
Or we can change the api to be
The warning system is only used here for 1 release before this warning is removed and made an error, and warnings (iirc) are still off by default because I was removing the warning system in favour of a simpler system. I was working on this but I'm still struggling to even keep up with github notifications with the time I have to work on crystal...
Let's just leave this as-is, since the whole warnings system may be removed. Discussion in #7655
I wasn’t able to spent time on this. I might tomorrow if I finish checking the ecosystem.
I see this as a first time where we can evolve smoothly the language semantics. I find it valuable to build the abstractions to implement these kind of things in the less error prone way as possible.