Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix examples 2019 07 #8003

Merged
merged 6 commits into from Jul 27, 2019

Conversation

@maiha
Copy link
Contributor

commented Jul 27, 2019

Congrats 0.29.0! Let's catch up the examples code too!

For convenience, commits are divided file by file, so please apply squash merge.

Best regards,

Show resolved Hide resolved src/channel.cr Outdated
@@ -60,7 +60,7 @@ class File < IO::FileDescriptor
# return EOF, and any data written will be immediately discarded.
#
# ```
# File.open(File::NULL) do |file|
# File.open(File::NULL, "w") do |file|

This comment has been minimized.

Copy link
@maiha

maiha Jul 27, 2019

Author Contributor

The original code causes an error as follows:

Unhandled exception: File not open for writing (IO::Error)
  from crystal/src/crystal/system/unix/file_descriptor.cr:20:11 in 'unbuffered_write'
  from crystal/src/io/buffered.cr:192:5 in 'flush'
  from crystal/src/io/buffered.cr:200:5 in 'close'
  from crystal/src/file.cr:595:7 in '__crystal_main'
@@ -29,7 +29,7 @@ require "c/errno"
# slice.size
# end
#
# def write(slice : Bytes)
# def write(slice : Bytes) : Nil

This comment has been minimized.

Copy link
@maiha

maiha Jul 27, 2019

Author Contributor

#7956 makes codes more reliable 👍

Revert "examples: fix Channel"
This reverts commit 0302ef8.

@straight-shoota straight-shoota added this to the 0.30.0 milestone Jul 27, 2019

@bcardiff bcardiff merged commit 6d8ef2d into crystal-lang:master Jul 27, 2019

5 checks passed

ci/circleci: check_format Your tests passed on CircleCI!
Details
ci/circleci: test_darwin Your tests passed on CircleCI!
Details
ci/circleci: test_linux Your tests passed on CircleCI!
Details
ci/circleci: test_linux32 Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@maiha maiha deleted the maiha:fix-examples-2019-07 branch Jul 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.