Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP::Request: follow up fixes #8009

merged 2 commits into from Jul 30, 2019


Copy link

commented Jul 29, 2019

Follow up to #8002

@asterite asterite requested a review from RX14 Jul 29, 2019

@asterite asterite changed the title HTTP::Request: consider `\n` in addition to `\r\n` in optimized path HTTP::Request: follow up fixes Jul 29, 2019

@asterite asterite referenced this pull request Jul 29, 2019


Http optimizations #8002


it "parses empty string (EOF), returns nil (no peek)" do
Request.from_io( be_nil

This comment has been minimized.

Copy link

straight-shoota Jul 30, 2019


This is fine, but it's actually the only spec explicitly for a non-peek IO. We should probably run every request spec against both a peekable and non-peekable IO (not in this PR though).


RX14 approved these changes Jul 30, 2019

@RX14 RX14 added this to the 0.30.0 milestone Jul 30, 2019

@asterite asterite merged commit dc882ea into crystal-lang:master Jul 30, 2019

4 of 5 checks passed

ci/circleci: test_linux32 Your tests failed on CircleCI
ci/circleci: check_format Your tests passed on CircleCI!
ci/circleci: test_darwin Your tests passed on CircleCI!
ci/circleci: test_linux Your tests passed on CircleCI!
continuous-integration/travis-ci/pr The Travis CI build passed

@asterite asterite deleted the asterite:http-optimizations-fixes branch Jul 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
3 participants
You can’t perform that action at this time.