Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler: consider abstract method implementation in supertype #8035

Merged
merged 1 commit into from Aug 6, 2019

Conversation

@asterite
Copy link
Member

commented Aug 2, 2019

Fixes #8031

Note that there are still cases that work work well when a method is implemented by a supertype (who would have thought it?) but I'll (try to) fix those in a separate PR.

@ysbaddaden
Copy link
Member

left a comment

Who would have thought?

Well, that was in stdlib 😄

@asterite asterite merged commit 06413bc into crystal-lang:master Aug 6, 2019

5 checks passed

ci/circleci: check_format Your tests passed on CircleCI!
Details
ci/circleci: test_darwin Your tests passed on CircleCI!
Details
ci/circleci: test_linux Your tests passed on CircleCI!
Details
ci/circleci: test_linux32 Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@asterite asterite deleted the asterite:abstract-def-check-bug branch Aug 6, 2019

@bcardiff bcardiff modified the milestones: 0.31.0, 0.30.1 Aug 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.