Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate redundant OptionParser#parse! #8041

Merged
merged 1 commit into from Aug 11, 2019

Conversation

@didactic-drunk
Copy link
Contributor

commented Aug 4, 2019

Partially based on @chocolateboy's suggestion, @jhass's thumbs up in #7846 and review requests by @straight-shoota to prefer arguments over additional methods.

OptionParser#parse! deprecate.
@didactic-drunk didactic-drunk force-pushed the didactic-drunk:optparse_order2 branch from e245557 to adb2ce8 Aug 5, 2019
@didactic-drunk didactic-drunk changed the title Deprecate redundant OptionParser#order! Deprecate redundant OptionParser#parse! Aug 5, 2019
@jhass
jhass approved these changes Aug 5, 2019
@RX14
RX14 approved these changes Aug 11, 2019
@RX14 RX14 added this to the 0.31.0 milestone Aug 11, 2019
@RX14 RX14 merged commit 61bc4d7 into crystal-lang:master Aug 11, 2019
4 of 5 checks passed
4 of 5 checks passed
ci/circleci: test_linux32 Your tests failed on CircleCI
Details
ci/circleci: check_format Your tests passed on CircleCI!
Details
ci/circleci: test_darwin Your tests passed on CircleCI!
Details
ci/circleci: test_linux Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@didactic-drunk didactic-drunk deleted the didactic-drunk:optparse_order2 branch Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.