Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JSON and YAML parsing of NamedTuple with nilable fields #8109

Merged

Conversation

@asterite
Copy link
Member

commented Aug 22, 2019

Fixes #8089

@jhass
jhass approved these changes Aug 23, 2019
@asterite asterite added this to the 0.31.0 milestone Aug 23, 2019
@asterite asterite merged commit 41cca62 into crystal-lang:master Aug 23, 2019
5 checks passed
5 checks passed
ci/circleci: check_format Your tests passed on CircleCI!
Details
ci/circleci: test_darwin Your tests passed on CircleCI!
Details
ci/circleci: test_linux Your tests passed on CircleCI!
Details
ci/circleci: test_linux32 Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@asterite asterite deleted the asterite:feature/json-named-tuple-nilable branch Aug 23, 2019
@asterite

This comment has been minimized.

Copy link
Member Author

commented Aug 23, 2019

@jhass Thank you for all the reviews! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.