Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YAML: emit unicode characters as such #8132

Merged
merged 1 commit into from Aug 31, 2019

Conversation

@asterite
Copy link
Member

commented Aug 31, 2019

Fixes #8131

Eventually we can make this configurable. I checked with Ruby's Psych and it's not configurable. Additionally, I never though about YAML not doing this by default and I don't know in which case I'd like to turn this off. But if we want to do that, let's do it as a separate issue/PR.

@asterite asterite force-pushed the asterite:bug/yaml-emit-unicode branch from 0406bcb to 83104c7 Aug 31, 2019
@jhass
jhass approved these changes Aug 31, 2019
@asterite asterite added this to the 0.31.0 milestone Aug 31, 2019
@asterite asterite merged commit 824ad98 into crystal-lang:master Aug 31, 2019
5 checks passed
5 checks passed
ci/circleci: check_format Your tests passed on CircleCI!
Details
ci/circleci: test_darwin Your tests passed on CircleCI!
Details
ci/circleci: test_linux Your tests passed on CircleCI!
Details
ci/circleci: test_linux32 Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@asterite asterite deleted the asterite:bug/yaml-emit-unicode branch Aug 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.