Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XML:: rename XML::Type to XML::Node::Type, introduce XML::Reader::Type #8134

Merged
merged 1 commit into from Sep 3, 2019

Conversation

@asterite
Copy link
Member

commented Aug 31, 2019

Fixes #8129

We incorrectly had a single enum for xml node types when in reality there are two enums: one for node types for XML::Node, another for the node types returned by XML::Reader.

Marking as a breaking change because XML::Type is renamed to XML::Node::Type, and the type of XML::Reader#node_type changed too.

We incorrectly had a single enum for xml node types when in reality
there are two enums: one for node types for `XML::Node`, another for the
node types returned by `XML::Reader`.
src/xml/node.cr Show resolved Hide resolved
@asterite asterite added this to the 0.31.0 milestone Sep 3, 2019
@asterite asterite merged commit f2a90ba into crystal-lang:master Sep 3, 2019
5 checks passed
5 checks passed
ci/circleci: check_format Your tests passed on CircleCI!
Details
ci/circleci: test_darwin Your tests passed on CircleCI!
Details
ci/circleci: test_linux Your tests passed on CircleCI!
Details
ci/circleci: test_linux32 Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@asterite asterite deleted the asterite:bug/xml-reader-type branch Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.