Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate compiler warnings by default #8171

Merged
merged 2 commits into from Sep 13, 2019

Conversation

@bcardiff
Copy link
Member

commented Sep 10, 2019

Meanwhile... fix some deprecation warnings in the specs and docs.

Now that #8120 is merged, we can activate warnings since there should not be false positives.

@bcardiff bcardiff force-pushed the bcardiff:feature/activate-warnings branch from 78f82f1 to 4a0dc6b Sep 10, 2019
@bcardiff bcardiff merged commit 037705c into crystal-lang:master Sep 13, 2019
6 checks passed
6 checks passed
ci/circleci: check_format Your tests passed on CircleCI!
Details
ci/circleci: test_darwin Your tests passed on CircleCI!
Details
ci/circleci: test_linux Your tests passed on CircleCI!
Details
ci/circleci: test_linux32 Your tests passed on CircleCI!
Details
ci/circleci: test_preview_mt Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bcardiff bcardiff added this to the 0.31.0 milestone Sep 16, 2019
@bcardiff bcardiff deleted the bcardiff:feature/activate-warnings branch Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.