Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XML::Reader#expand changes #8186

Merged
merged 1 commit into from Oct 31, 2019

Conversation

@Blacksmoke16
Copy link
Contributor

Blacksmoke16 commented Sep 15, 2019

  • Makes XML::Reader#expand raise a XML::Error if the node could not be expanded.
  • Adds a new method XML::Reader#expand? that retains the previous behavior of returning nil on error.
Add new method that returns nil instead
@RX14
RX14 approved these changes Sep 18, 2019
@Blacksmoke16

This comment has been minimized.

Copy link
Contributor Author

Blacksmoke16 commented Oct 31, 2019

Anything left to do here?

@straight-shoota straight-shoota merged commit 644c55c into crystal-lang:master Oct 31, 2019
5 of 6 checks passed
5 of 6 checks passed
ci/circleci: test_preview_mt Your tests failed on CircleCI
Details
ci/circleci: check_format Your tests passed on CircleCI!
Details
ci/circleci: test_darwin Your tests passed on CircleCI!
Details
ci/circleci: test_linux Your tests passed on CircleCI!
Details
ci/circleci: test_linux32 Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@straight-shoota straight-shoota added this to the 0.32.0 milestone Oct 31, 2019
@straight-shoota

This comment has been minimized.

Copy link
Member

straight-shoota commented Oct 31, 2019

Thank you

@Blacksmoke16 Blacksmoke16 deleted the Blacksmoke16:xml-reader-expand branch Nov 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.