Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : Channel can send successfully but raise #8284

Merged

Conversation

@firejox
Copy link
Contributor

firejox commented Oct 7, 2019

refer to #8269
It uses additional state to track whether the send is successful. If not, it will raise error.

@firejox firejox changed the title Fix : Channel can send successfully without raise Fix : Channel can send successfully but raise Oct 7, 2019
@bcardiff bcardiff added this to the 0.32.0 milestone Oct 7, 2019
Copy link
Member

bcardiff left a comment

Looks good! Last week I was also dealing with the asymmetry of receive & send regarding the delivery state.

@bcardiff bcardiff requested a review from waj Oct 7, 2019
src/channel.cr Outdated Show resolved Hide resolved
@firejox firejox force-pushed the firejox:fix-inconsistency-channel-send branch from 4cd4278 to b76b1fb Oct 8, 2019
@bcardiff bcardiff force-pushed the firejox:fix-inconsistency-channel-send branch from b76b1fb to 35148e2 Oct 8, 2019
@bcardiff

This comment has been minimized.

Copy link
Member

bcardiff commented Oct 8, 2019

@firejox I will rebase this over master so the test_preview_mt can build

@waj
waj approved these changes Oct 8, 2019
@bcardiff bcardiff merged commit 49e67de into crystal-lang:master Oct 8, 2019
4 of 5 checks passed
4 of 5 checks passed
ci/circleci: test_linux32 Your tests failed on CircleCI
Details
ci/circleci: check_format Your tests passed on CircleCI!
Details
ci/circleci: test_linux Your tests passed on CircleCI!
Details
ci/circleci: test_preview_mt Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@firejox firejox deleted the firejox:fix-inconsistency-channel-send branch Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.