Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get the class variables of some Type in a macro #8405

Merged
merged 3 commits into from Oct 31, 2019

Conversation

@jan-zajic
Copy link
Contributor

jan-zajic commented Oct 30, 2019

This PR fix issue #6417.

src/compiler/crystal/types.cr Outdated Show resolved Hide resolved
src/compiler/crystal/types.cr Outdated Show resolved Hide resolved
@jan-zajic

This comment has been minimized.

Copy link
Contributor Author

jan-zajic commented Oct 30, 2019

Ok @bcardiff, i make it same and add some aditional specs.

@@ -974,6 +987,16 @@ module Crystal

nil
end

def declare_class_var(name, type : Type, annotations = nil)

This comment has been minimized.

Copy link
@bcardiff

bcardiff Oct 30, 2019

Member

I just noticed that delcare_class_var is only used in specs, so to avoid reviewing all the places where ClassVarContainer is included I would suggest moving this method to a private helper in the spec.

This comment has been minimized.

Copy link
@jan-zajic

jan-zajic Oct 31, 2019

Author Contributor

@bcardiff, something like that?

Copy link
Member

bcardiff left a comment

Exactly, thanks!

@bcardiff bcardiff added this to the 0.32.0 milestone Oct 31, 2019
@bcardiff bcardiff merged commit 774cc13 into crystal-lang:master Oct 31, 2019
6 checks passed
6 checks passed
ci/circleci: check_format Your tests passed on CircleCI!
Details
ci/circleci: test_darwin Your tests passed on CircleCI!
Details
ci/circleci: test_linux Your tests passed on CircleCI!
Details
ci/circleci: test_linux32_std Your tests passed on CircleCI!
Details
ci/circleci: test_preview_mt Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
didactic-drunk added a commit to didactic-drunk/crystal that referenced this pull request Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.