Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow getting a TypeNode's name without type vars #8483

Merged

Conversation

@Blacksmoke16
Copy link
Contributor

Blacksmoke16 commented Nov 17, 2019

Follow up to #8458, was easier to redo the branch versus figuring out git 馃槵.

@RX14
RX14 approved these changes Nov 21, 2019
@straight-shoota

This comment has been minimized.

Copy link
Member

straight-shoota commented Jan 7, 2020

@Blacksmoke16 Needs a rebase.

@Blacksmoke16 Blacksmoke16 force-pushed the Blacksmoke16:typenode-name-generic-args branch from 5132d3a to 8d2b6e3 Jan 7, 2020
@Blacksmoke16

This comment has been minimized.

Copy link
Contributor Author

Blacksmoke16 commented Jan 13, 2020

This is ready to go btw, @straight-shoota

@straight-shoota straight-shoota merged commit 5d06852 into crystal-lang:master Jan 13, 2020
6 checks passed
6 checks passed
ci/circleci: check_format Your tests passed on CircleCI!
Details
ci/circleci: test_darwin Your tests passed on CircleCI!
Details
ci/circleci: test_linux Your tests passed on CircleCI!
Details
ci/circleci: test_linux32_std Your tests passed on CircleCI!
Details
ci/circleci: test_preview_mt Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@straight-shoota

This comment has been minimized.

Copy link
Member

straight-shoota commented Jan 13, 2020

Thanks

@Blacksmoke16 Blacksmoke16 deleted the Blacksmoke16:typenode-name-generic-args branch Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can鈥檛 perform that action at this time.