Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reporting of non-statement rows in DWARF backtrace #8499

Merged
merged 2 commits into from Jan 7, 2020

Conversation

@rdp
Copy link
Contributor

rdp commented Nov 21, 2019

be more selective in which operations we respect as backtrace appropriate

Fixes #8319

@RX14
RX14 approved these changes Nov 25, 2019
Copy link
Member

RX14 left a comment

If it works...

Having an expert or gdb/llvm maintainer chip in would be great but oh well.

@rdp

This comment has been minimized.

Copy link
Contributor Author

rdp commented Dec 3, 2019

Yeah it does seem to work. Confusing as to why the emitter would consider "anything" to be at "line 0 column 9" but it works around it... :)

@bcardiff bcardiff added this to the 0.33.0 milestone Dec 16, 2019
@straight-shoota straight-shoota changed the title be more selective in which operations we respect as backtrace appropr… Fix reporting of non-statement rows in DWARF backtrace Jan 7, 2020
@straight-shoota straight-shoota merged commit 2d02e52 into crystal-lang:master Jan 7, 2020
5 of 6 checks passed
5 of 6 checks passed
ci/circleci: test_preview_mt Your tests failed on CircleCI
Details
ci/circleci: check_format Your tests passed on CircleCI!
Details
ci/circleci: test_darwin Your tests passed on CircleCI!
Details
ci/circleci: test_linux Your tests passed on CircleCI!
Details
ci/circleci: test_linux32_std Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@straight-shoota

This comment has been minimized.

Copy link
Member

straight-shoota commented Jan 7, 2020

Thank you @rdp ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

6 participants
You can’t perform that action at this time.