Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mutex specs race condition on mt #8643

Merged
merged 1 commit into from Jan 3, 2020

Conversation

@bcardiff
Copy link
Member

bcardiff commented Jan 2, 2020

In https://circleci.com/gh/crystal-lang/crystal/36001 I experienced a race condition introduced in #8563 .

After this changes the loop will not only wait for the mutex to be assigned but for the lock to occur.

@RX14
RX14 approved these changes Jan 2, 2020
@RX14

This comment has been minimized.

Copy link
Member

RX14 commented Jan 2, 2020

nice catch, weird ci didnt properly trigger here though...

@bcardiff bcardiff merged commit 15bfc23 into crystal-lang:master Jan 3, 2020
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
ci/circleci: test_darwin Your tests passed on CircleCI!
Details
@bcardiff bcardiff deleted the bcardiff:fix/mutex-spec branch Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.