Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Object#in? #8720

Merged
merged 1 commit into from Jan 28, 2020
Merged

Add Object#in? #8720

merged 1 commit into from Jan 28, 2020

Conversation

@Sija
Copy link
Contributor

Sija commented Jan 28, 2020

Closes #8671

src/object.cr Outdated Show resolved Hide resolved
src/object.cr Show resolved Hide resolved
@Sija Sija force-pushed the Sija:object-in branch 2 times, most recently from 65ad284 to 5ef498e Jan 28, 2020
@RX14
RX14 approved these changes Jan 28, 2020
@RX14 RX14 added this to the 0.33.0 milestone Jan 28, 2020
@RX14 RX14 merged commit 6e907b1 into crystal-lang:master Jan 28, 2020
5 of 6 checks passed
5 of 6 checks passed
ci/circleci: test_darwin CircleCI is running your tests
Details
ci/circleci: check_format Your tests passed on CircleCI!
Details
ci/circleci: test_linux Your tests passed on CircleCI!
Details
ci/circleci: test_linux32_std Your tests passed on CircleCI!
Details
ci/circleci: test_preview_mt Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@straight-shoota

This comment has been minimized.

Copy link
Member

straight-shoota commented Jan 28, 2020

Do we really want the splat overload? I agree with @asterite that it's confusing (#8720 (comment)).

@asterite

This comment has been minimized.

Copy link
Member

asterite commented Jan 28, 2020

Nevermind, maybe it's good and convenient.

src/object.cr Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

7 participants
You can’t perform that action at this time.