Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure sending fiber finished in select specs #8724

Merged
merged 2 commits into from Jan 31, 2020

Conversation

@bcardiff
Copy link
Member

bcardiff commented Jan 30, 2020

These specs are failing every now and then on preview_mt.

The changes ensure the sending fiber finished executing before performing the assertion in the main fiber.

Sample of the failure: https://circleci.com/gh/crystal-lang/crystal/37483?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

@bcardiff bcardiff added this to the 0.33.0 milestone Jan 31, 2020
@bcardiff bcardiff merged commit 7fc7379 into crystal-lang:master Jan 31, 2020
8 checks passed
8 checks passed
linux-job
Details
windows-job
Details
ci/circleci: check_format Your tests passed on CircleCI!
Details
ci/circleci: test_darwin Your tests passed on CircleCI!
Details
ci/circleci: test_linux Your tests passed on CircleCI!
Details
ci/circleci: test_linux32_std Your tests passed on CircleCI!
Details
ci/circleci: test_preview_mt Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.