New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Win CI: Bootstrap Crystal, build things *on* Windows, publish the binary #9123
Conversation
We can move de GitHub Action to build LLVM for windows to distributions-script repo. That is already done for the omnibus osx packages using CircleCI. Once built we can drop it in the same S3 bucket. |
Did you try with binaries released at https://releases.llvm.org/download.html#10.0.0 or https://github.com/llvm/llvm-project/releases? |
@waj Yes. From my post:
@bcardiff's suggestion seems good. This will work as is anyway and can be merged. The building and caching is very stable. |
I was just thinking, maybe this approach to LLVM isn't even bad. Everything is declared explicitly, which is nice. But even better, with the cache this doesn't have any outbound traffic as far as GitHub is concerned :) |
Well, the Mac CI failure is obviously unrelated. |
@oprypin rebasing on top of |
Yes but that's a heavy-handed move, as reviewers would need to double check that the commits have the same content. |
Ah well, not a big deal here 😬 |
Oh it is a big deal apparently. Does GitHub now dismiss reviews on force push? Nice. |
It's a setting we flipped on. |
please :s |
As you wish =) Thank you! |
Example:
First run: https://github.com/crystal-lang/crystal/runs/598199987
With cache: https://github.com/crystal-lang/crystal/runs/598303791
Sadly, LLVM here, if not cached, takes 1 hour to build. Although future builds will not need to build it, this might be too much reliance on the cache. Ideally Crystal org would provide a pre-built LLVM download. There is no official download that has the necessary "*.lib" files. Zig lang provides LLVM downloads but surely we can't just use it.
In the future, if there is also a permanent place to grab a "crystal.exe" from, we can just drop the Linux step from this.