Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support linking to section headings in same tab #9826

Merged
merged 2 commits into from Jan 7, 2021
Merged

Support linking to section headings in same tab #9826

merged 2 commits into from Jan 7, 2021

Conversation

Blacksmoke16
Copy link
Member

@Blacksmoke16 Blacksmoke16 commented Oct 14, 2020 •
edited

Allows doing like:

# # Main Heading
# 
# Some text
# 
# ## Sub Heading
#
# [Back to top](#main-heading)

The Back to top link will now take you to the Main Heading heading in same same tab. Old behavior was opening that section in a new tab. Links to sections in other files, or external links, will still open a new tab.

@straight-shoota
Copy link
Member

I'd suggest to remove target="_blank" entirely. Reasons: https://css-tricks.com/use-target_blank/

@Blacksmoke16
Copy link
Member Author

@straight-shoota Yea that works for me, done.

@Blacksmoke16
Copy link
Member Author

Good to merge?

@asterite asterite merged commit a2f6ebe into crystal-lang:master Jan 7, 2021
@asterite asterite added this to the 1.0.0 milestone Jan 7, 2021
@Blacksmoke16 Blacksmoke16 deleted the link-to-anchor-tag branch January 7, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oprypin oprypin oprypin left review comments

@jhass jhass jhass approved these changes

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:bug topic:tools:docs-generator
Projects
None yet
Milestone
0.36.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Blacksmoke16 @straight-shoota @jhass @oprypin @asterite