Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snap target #39

Merged
merged 4 commits into from Jun 17, 2019

Conversation

Projects
None yet
3 participants
@bcardiff
Copy link
Member

commented Jun 13, 2019

The maintenance and tagged builds are already stressed in

This will be used to ship nightly builds to snap.

The snap is built by embedding a known tar.gz that can be a url or a local path

if [ ! -f $SNAP_USER_COMMON/env-check-success ]; then
# check if a simple program can be compiled
# if something fails show a banner to the user

This comment has been minimized.

Copy link
@straight-shoota

straight-shoota Jun 14, 2019

Member

Is this the general wrapper which you use to run crystal in snap? Compiling even a little program would delay the actual compiler boot time and make it appear to be slow.
Can't there be a different solution to this? Maybe use the actual error code from the invoked crystal command?

This comment has been minimized.

Copy link
@bcardiff

bcardiff Jun 14, 2019

Author Member

That could be another way to do it but exec is used to run the compiler and I don't think something can be done after that.

Using exec to delegate is better so the wrapper is more transparent.

As soon as the env is verified once the check will no longer run so is a one time delay.

Unfortunately, there is no support for post-installation messages on snap for now. I would have preferred to do it that way.

@bcardiff bcardiff merged commit 34f76b4 into master Jun 17, 2019

@straight-shoota straight-shoota deleted the snap branch Jun 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.