Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make shards reproducible #314

Merged
merged 1 commit into from Jan 19, 2020
Merged

Make shards reproducible #314

merged 1 commit into from Jan 19, 2020

Conversation

@jelly
Copy link
Contributor

jelly commented Jan 15, 2020

By default the shards binary embeds a build date which makes it
impossible to rebuild due to time differences. Use SOURCE_DATE_EPOCH to
use a predictable timestamp as input for the date function which in turn
makes shards reproducible.

Motiviation: https://reproducible-builds.org

src/version.cr Outdated Show resolved Hide resolved
@jelly jelly force-pushed the jelly:reproducible branch from 32c0602 to 658745d Jan 18, 2020
src/version.cr Outdated Show resolved Hide resolved
@jelly jelly force-pushed the jelly:reproducible branch 2 times, most recently from cffc069 to e1deef6 Jan 18, 2020
By default the shards binary embeds a build date which makes it
impossible to rebuild due to time differences. Use SOURCE_DATE_EPOCH to
use a predictable timestamp as input for the date function which in turn
makes shards reproducible.

Motiviation: https://reproducible-builds.org
@RX14
RX14 approved these changes Jan 18, 2020
@ysbaddaden ysbaddaden merged commit 35303e1 into crystal-lang:master Jan 19, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.