Added discussion on how and when to use cheat codes #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xPhaze
reviewed
Mar 24, 2023
Contributor
0xPhaze
left a comment
0xPhaze
left a comment
There was a problem hiding this comment.
I would further include the example of vm.mockCall. Imo it is a big red flag if seen in tests. It has similar issues to vm.prank, however it further completely bypasses any business-logic and can easily break assumptions.
Contributor
Author
I think this should be part of another document on good testing practice, so we can discuss cheat codes that are not implemented in hevm/echidna. |
Contributor
Author
|
This one looks ready for another review or merging @montyly |
montyly
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.