Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove mstksg/get-package #952

Merged
merged 3 commits into from Feb 24, 2023
Merged

ci: remove mstksg/get-package #952

merged 3 commits into from Feb 24, 2023

Conversation

elopez
Copy link
Member

@elopez elopez commented Feb 22, 2023

This action has not been updated since 2019, and is currently causing some deprecation warnings to show up. This replaces it with a few run steps for each OS.

This action has not been updated since 2019, and is currently causing
some deprecation warnings to show up. This replaces it with a few run
steps for each OS.
@elopez elopez force-pushed the dev-clean-deprecation-warning branch from b61c0d4 to 9360b30 Compare February 22, 2023 19:21
These are already pre-installed on the GitHub runners:

    autoconf is already the newest version (2.69-11.1).
    automake is already the newest version (1:1.16.1-4ubuntu6).
    libtool is already the newest version (2.4.6-14).
The stack rule missed the local workdir, and some keys were missing
hashes to make them get cleared when necessary.
@elopez elopez force-pushed the dev-clean-deprecation-warning branch from bb495f4 to 6eb4cdd Compare February 22, 2023 20:15
@elopez elopez marked this pull request as ready for review February 22, 2023 21:04
@@ -37,19 +30,21 @@ jobs:
uses: actions/cache@v3
with:
path: ~/.local/
key: ${{ runner.os }}-local-v4
key: ${{ runner.os }}-local-v5-${{ hashFiles('.github/scripts/install-*') }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happened here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a hash of the scripts so it gets invalidated in case we ever update a dependency. Right now the cache has a fixed name and it'll still use old binaries even if we update the scripts.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds like a good change 👍

@arcz arcz merged commit 19c6658 into master Feb 24, 2023
@arcz arcz deleted the dev-clean-deprecation-warning branch February 24, 2023 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants