Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom mimetypes config to the app provider #2813

Merged
merged 1 commit into from May 3, 2022

Conversation

glpatcern
Copy link
Member

Same as for the storage provider, this adds the ability to configure custom mimetypes to ext mappings for the WOPI app provider.

If it needs to be moved "up" at the appprovider level, it can be done at a later stage. For now this only affects the WOPI driver as it is extension-based, whereas the appprovider is mimetype-based in general.

@update-docs
Copy link

update-docs bot commented May 2, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@micbar
Copy link
Member

micbar commented May 2, 2022

@glpatcern Do you need that in master? Or can you merge to edge?

@glpatcern
Copy link
Member Author

@micbar I need it in master but I guess it's for both anyway!

@glpatcern glpatcern requested a review from a team as a code owner May 2, 2022 15:11
@sonarcloud
Copy link

sonarcloud bot commented May 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@ishank011 ishank011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@micbar can someone from @cs3org/owncloud-team create a master to edge merge next week?

@ishank011 ishank011 merged commit bd0d4ea into cs3org:master May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants