Fix propagation in concurrency scenarios #3845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the previous code the propagation code read the parent node before grabbing the according write lock. That had the effect that when a directory was being updated concurrently by different operations the calculations were made on an outdated state, leading to incorrect numbers. After this change we grab the lock BEFORE actually reading the node which ensures that we always work with the proper data.
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
butonic
approved these changes
May 4, 2023
9 tasks
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the previous code the propagation code read the parent node before grabbing the according write lock. That had the effect that when a directory was being updated concurrently by different operations the calculations were made on an outdated state, leading to incorrect numbers.
After this change we grab the lock BEFORE actually reading the node which ensures that we always work with the proper data.
Fixes owncloud/ocis#6215