Skip to content

Conversation

@benedictbrown
Copy link

nocomments pass strips comments but preserves whitespace. verbatim preserves comments and whitespace (as opposed to exact that strips whitespace). Preserving whitespace can be useful, especially in CS1 classes.

@cmlsharp
Copy link
Contributor

cmlsharp commented Nov 12, 2019

I think the more passes we add, the less sense it makes to run every pass by default. Mainly for usability reasons (e.g. the differences between 'exact' and 'verbatim' might be confusing to a new u
user), but a little for performance I guess as well.

I added a bit of code to allow passes to be marked as default or not (via a class variable). There's probably a discussion worth having over what passes should be enabled by default but for now I just marked the three existing ones as default. The new passes can still be enabled at runtime via -p. Does this seem reasonable?

@Jelleas Jelleas merged commit 2435161 into cs50:develop Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants