Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Students assume 50 jpgs and hard-code their loops which then fail check50 #72

Closed
curiouskiwi opened this issue Feb 27, 2017 · 1 comment

Comments

@curiouskiwi
Copy link
Collaborator

The spec explicitly says

But you should ultimately find that the image contains 50 JPEGs.

This leads many students to assume they should hard-code their number of jpgs to 50 and structure their program this way (with a for loop that ends when 50 jpgs are found). This works perfectly fine with the card.raw that is in the distro code, but check50 uses a different raw file (with only 16 files) so their program is then "killed by server" because it never finds the 17th signature and goes into an infinite loop.

Should we add something like:

Note that your program may be tested with a different card image so you should not hard-code that number, but instead, search the entire file for all the JPEGs within it.

@dlloyd09
Copy link
Contributor

Sure, we can do this. Let me think of how best to phrase a note for the Hints section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants