Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Three failing tests for whatthepatch.patch module #1

Closed
thoward opened this issue Sep 30, 2015 · 2 comments
Closed

Three failing tests for whatthepatch.patch module #1

thoward opened this issue Sep 30, 2015 · 2 comments

Comments

@thoward
Copy link
Contributor

thoward commented Sep 30, 2015

I found a small bug with the unified diff parsing, and was planning to submit a PR. In the process of doing that, I decided to run through the tests. However, I found that test_patch.py, at current master, has three failing tests.

Should I ignore those and assume that if nothing new breaks, my PR won't be introducing breaking changes?

The failing tests are:

Thanks,
Troy

@cscorley
Copy link
Owner

cscorley commented Oct 1, 2015

Yes, these tests have been broken for quite some time. They are examples of real diffs I've found that are not yet handled and are reminders for work yet done. I wouldn't worry about it :)

@cscorley
Copy link
Owner

Fixed these!

Thanks to your intuition in fixing #2, which I used to fix the _blah tests (that I should rename...). 🎅

cscorley pushed a commit that referenced this issue Jul 28, 2016
switch to new-style travis apt-get
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants