New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Three failing tests for whatthepatch.patch module #1
Comments
Yes, these tests have been broken for quite some time. They are examples of real diffs I've found that are not yet handled and are reminders for work yet done. I wouldn't worry about it :) |
cscorley
added a commit
that referenced
this issue
Dec 25, 2015
cscorley
added a commit
that referenced
this issue
Dec 25, 2015
cscorley
added a commit
that referenced
this issue
Dec 25, 2015
Fixed these! Thanks to your intuition in fixing #2, which I used to fix the _blah tests (that I should rename...). 🎅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I found a small bug with the unified diff parsing, and was planning to submit a PR. In the process of doing that, I decided to run through the tests. However, I found that
test_patch.py
, at current master, has three failing tests.Should I ignore those and assume that if nothing new breaks, my PR won't be introducing breaking changes?
The failing tests are:
Thanks,
Troy
The text was updated successfully, but these errors were encountered: