Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To do before first release #1

Closed
33 of 34 tasks
csdaw opened this issue May 8, 2020 · 0 comments
Closed
33 of 34 tasks

To do before first release #1

csdaw opened this issue May 8, 2020 · 0 comments
Assignees
Labels
to do On my plan

Comments

@csdaw
Copy link
Owner

csdaw commented May 8, 2020

In no particular order

  • Clean up guide_prism_minor and make changes more explicit
  • Remove ggplot-internal.R and replace with pulls from ggplot2 NAMESPACE (see teunbrand/ggh4x)
  • Decide if annotation_ticks is useful or can be removed
  • Fix tick length determination/defaults in annotation_ticks
  • Decide if imports can stay in ggprism-package.R or should be moved to the functions in which they are used
  • Check that scale_fill_prism has the correct structure
  • Check that scale_shape_prism has the correct structure
  • Make line elements in theme_prism inherit from base_line_size? Not sure about this one...
  • Make axes automatically disappear if frame = TRUE in theme_prism, or at least play around with panel.border
  • Add Makefile for package build
  • Improve Makefile to make life easier
  • Add scale_colour/color_prism functions
  • Add the colour palettes that underlie scale_colour_prism
  • Make file names in data-raw more consistent
  • Put schemes all in the same directory
  • Make README more informative
  • Recreate a figure from a paper in the README
  • Add .pdf with all colour schemes
  • Add useful packages to suggests e.g. rstatix, ggbeeswarm, etc.
  • Recreate some common figure types in a vignette

Document and add examples for:

  • annotation_ticks
  • ggprism-package
  • ggprism_data
  • guide_prism_minor
  • scale_fill_prism
  • scale_colour_prism
  • scale_shape_prism
  • theme_prism

Add tests for:

  • annotation_ticks
  • guide_prism_minor
  • scale_fill_prism
  • scale_colour_prism
  • scale_shape_prism
  • theme_prism
@csdaw csdaw self-assigned this May 8, 2020
@csdaw csdaw added the to do On my plan label May 8, 2020
@csdaw csdaw closed this as completed Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
to do On my plan
Projects
None yet
Development

No branches or pull requests

1 participant