Replace #include <math.h> with #include <cmath> #454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nealkruis
reviewed
Dec 18, 2023
|
I decided to leave it where it is (within the #if defined( AIRNET_EIGEN))
…On Mon, Dec 18, 2023 at 3:07 PM Neal Kruis ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/cgcomp.cpp
<#454 (comment)>:
> @@ -2283,8 +2276,6 @@ void TOPRAT::tp_AirNetDestroy()
// finds zone pressures that achieve balanced mass flows
///////////////////////////////////////////////////////////////////////////////
#if defined( AIRNET_EIGEN)
-// Eigen #include located here because placement of top of file altered
-// code generation associated with pow() (4-12-2023). Cause not known.
#include <Eigen\Dense>
Move this up now?
—
Reply to this email directly, view it on GitHub
<#454 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACWGW7BSZNDYTTQHZHFGMTLYKCO63AVCNFSM6AAAAABAZ57WJ6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOOBXGYZDINJTGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation: standardize math-related declarations using cmath.
Prior to this change, cnglob.h included math.h. Some vendor headers included cmath. The Microsoft library can end up using different implementations of some functions (e.g. pow()) depending on include order. CSE results change when these alternative implementations are selected. Overall upshot -- adding or re-ordering includes of vendor headers could cause apparently unrelated results changes.
The primary code change in this PR is changing cnglob.h to #include <cmath>. Some redundant includes were removed. Related comments are updated.
Many regression tests show differences as a result of this change. Most are deemed trivial. In all cases, annual results are virtually unchanged. Larger and potentially significant changes are seen in hourly results in the following --