Skip to content

Conversation

@nealkruis
Copy link
Contributor

Fixes #19.

@nealkruis nealkruis self-assigned this Jan 23, 2019
@nealkruis nealkruis requested a review from chipbarnaby January 23, 2019 22:17
@nealkruis
Copy link
Contributor Author

@chipbarnaby interestingly, the tests results don't change at all. I imagine all the test files with buildings (not the PV/battery/shading tests) are getting sky temperature from CSW weather files.

@nealkruis
Copy link
Contributor Author

@chipbarnaby this does impact Standard 140 tests some, though.

@chipbarnaby
Copy link
Contributor

chipbarnaby commented Jan 25, 2019 via email

@nealkruis
Copy link
Contributor Author

@chipbarnaby Is this good to merge? If so, can you accept the review and hit the merge button?

@chipbarnaby chipbarnaby merged commit a9898d2 into master Jan 28, 2019
@nealkruis nealkruis deleted the sky-temp branch April 9, 2019 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants